Re: [PATCH v4 1/5] i2c: nvidia-gpu: refactor master_xfer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Changes from v3->v4:
> 	- Further refactor master_xfer based on Wolfram's comment.

Yay, looks even better. One thing to improve, though.

>  	status = gpu_i2c_stop(i2cd);

send_stop = false;

> -	if (status < 0)
> -		return status;
> +	if (status < 0) {
> +		send_stop = false;

and skip it here...

> +		goto exit;
> +	}
>  
> -	return i;
> -stop:
> -	status2 = gpu_i2c_stop(i2cd);
> -	if (status2 < 0)
> -		dev_err(i2cd->dev, "i2c stop failed %d\n", status2);
> +	send_stop = false;

... and here.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux