Hi Greg,
On Wed, Jun 5, 2019 at 11:21 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 27749ace2d93..92132b35b7fd 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -523,8 +523,9 @@ int hw_device_reset(struct ci_hdrc *ci)
> > hw_write(ci, OP_USBMODE, USBMODE_SLOM, USBMODE_SLOM);
> >
> > if (hw_read(ci, OP_USBMODE, USBMODE_CM) != USBMODE_CM_DC) {
> > - pr_err("cannot enter in %s device mode", ci_role(ci)->name);
> > - pr_err("lpm = %i", ci->hw_bank.lpm);
> > + dev_err(ci->dev, "cannot enter in %s mode\n",
>
> You changed the string text, why?
I mentioned this string change in the commit log.
Originally we could have the following error message:
cannot enter in host device mode
This "host device" message looks strange, so that's why I removed the
"device" string.
If you prefer, I can split it in three patches (add newline, remove
'device' string, change to dev_err).
Thanks
