Re: [PATCH v2] usb: dwc3: move core validation to be after clks enable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Baruch,

Baruch Siach wrote:
> Hi Jun Li,
>
> On Wed, May 08, 2019 at 10:52:37AM +0000, Jun Li wrote:
>> From: Jun Li <jun.li@xxxxxxx>
>>
>> Register access in core validation may hang before the bulk
>> clks are enabled.
> This patch fixes the hang issue for on my i.MX8MQ based system.
>
> Tested-by: Baruch Siach <baruch@xxxxxxxxxx>
>
> However, commit b873e2d0ea1e is meant to move dwc3_core_is_valid() before 
> dwc3_get_dr_mode(). With this patch dwc3_get_dr_mode() is called from 
> dwc3_get_properties() before dwc3_core_is_valid().
>
> I guess we need a larger change in the initialization sequence.
>
> Thanks,
> baruch
>

Look again. dwc3_get_dr_mode() is not called from dwc3_get_properties().

This patch is fine.

BR,
Thinh




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux