Hi Biju-san, > From: Biju Das, Sent: Tuesday, May 21, 2019 4:10 PM > > Hi Shimoda-San, > > Thanks for the feedback. > > > > From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM > > > Subject: [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role > > > switch support > > > > Now I'm confusing about the "Add dual role switch support" mean... > > Especially, this driver has already supports dual role switch support by own > > sysfs or debugfs. > > Sorry for the confusion. > What about "Enhance role switch support" ? Thank you for the suggestion. It's good to me. > > > The RZ/G2E cat874 board has a type-c connector connected to hd3ss3220 > > > usb type-c drp port controller. This patch adds dual role switch > > > support for the type-c connector using the usb role switch class framework. > > > > IIUC, after this patch is applied, the hs3ss3220 type-c driver can switch the > > role by using the usb role switch class framework. > > Yes, That is correct. HD3SS3220 driver detects host/device connection events (attach/detach) and > It calls "usb_role_switch_set_role" to assign/switch the role. I got it. <snip> > > JFYI, according to the binding document [1], this "usb-role-switch" means: > > --- > > + - usb-role-switch: boolean, indicates that the device is capable of assigning > > + the USB data role (USB host or USB device) for a > > given > > + USB connector, such as Type-C, Type-B(micro). > > + see connector/usb-connector.txt. > > --- > > > > So, R-Car Gen3 / Salvator-XS cannot have this property because the board > > has Type-A connector. > > > > [1] https://patchwork.kernel.org/patch/10934835/ > > I have updated the binding patch to cover this[1] > [1]. https://patchwork.kernel.org/patch/10944631/ > Are you ok with this binding patch? I'm sorry, I overlooked the patch. I'll check it later. Best regards, Yoshihiro Shimoda
