Hi Chrisさん
Thank you for the patch!
> From: Chris Brandt, Sent: Friday, May 10, 2019 5:12 AM
>
> The RZ/A2 has an optional dedicated 48MHz clock input for the PLL.
> If a clock node named 'usb_x1' exists and set to non-zero, then we can
> assume we want it use it.
>
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> ---
> v2:
> * use 'usb_x1' clock node instead of 'renesas,uses_usb_x1' property
> ---
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
<snip>
> @@ -582,10 +587,12 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct rcar_gen3_chan *channel;
> + struct device_node *usb_x1_clk;
> struct phy_provider *provider;
> struct resource *res;
> const struct phy_ops *phy_usb2_ops;
> int irq, ret = 0, i;
> + u32 freq_usb = 0;
>
> if (!dev->of_node) {
> dev_err(dev, "This driver needs device tree\n");
> @@ -630,6 +637,13 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> }
> }
>
> + usb_x1_clk = of_find_node_by_name(NULL, "usb_x1");
> + if (usb_x1_clk) {
> + of_property_read_u32(usb_x1_clk, "clock-frequency", &freq_usb);
> + if (freq_usb)
> + channel->uses_usb_x1 = true;
> + }
> +
We need to call of_node_put(usb_x1_clk); here.
By the way, we can also use devm_clk_get() for it like the following driver:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/renesas/rcar-usb2-clock-sel.c#n135
Best regards,
Yoshihiro Shimoda
> /*
> * devm_phy_create() will call pm_runtime_enable(&phy->dev);
> * And then, phy-core will manage runtime pm for this device.
> --
> 2.16.1
