On Tue, May 07, 2019, Sergei Shtylyov wrote:
> > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> > @@ -408,7 +408,12 @@ static int rcar_gen3_phy_usb2_init(struct phy *p)
> > if (rcar_gen3_needs_init_otg(channel))
> > rcar_gen3_init_otg(channel);
> > rphy->otg_initialized = true;
> > - }
> > + } else
>
> Wait, don't we neeed {} here?
>
> > + /* Not OTG, so dr_mode should be set in PHY node */
> > + if (usb_get_dr_mode(channel->dev) == USB_DR_MODE_PERIPHERAL)
> > + writel(0x80000000, usb2_base + USB2_COMMCTRL);
> > + else
> > + writel(0x00000000, usb2_base + USB2_COMMCTRL);
Technically there is only 1 statement after the else (the 'if' which
will also include the 'else') statement. The coding rules say not to use
{ } if there is only 1 statement.
Chris
