On Tue, Apr 30, 2019 at 09:22:29AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will use interrupt worker to handle MSR change.
> This patch will fix the issue that interrupt work should stop
> in close() and suspend().
>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@xxxxxxxxx>
> +static int f81232_resume(struct usb_serial *serial)
> +{
> + struct usb_serial_port *port = serial->port[0];
> + int result;
> +
> + if (tty_port_initialized(&port->port)) {
> + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO);
> + if (result) {
> + dev_err(&port->dev, "submit interrupt urb failed: %d",
> + result);
I added the missing '\n' to the error message.
> + return result;
> + }
> + }
> +
> + return usb_serial_generic_resume(serial);
> +}
This also fixes the issue with interrupt events not being received
after a suspend cycle, so I added that to the commit message.
Johan
