Re: [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.4.2019 23.05, Raul Rangel wrote:
On Thu, Feb 07, 2019 at 05:48:16PM -0800, Andrey Smirnov wrote:
Xhci_handshake() implements the algorithm already captured by
readl_poll_timeout_atomic(). Convert the former to use the latter to
avoid repetition.

Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
Tested-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>
Reviewed-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>

This fixes a bug on the AMD Stoneyridge platform. usleep(1) sometimes
takes over 10ms. This means a 5 second timeout can easily take over 15
seconds which will trigger the watchdog and reboot the system.

Thanks for the patch.

Adding to queue

-Mathias




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux