Hi, On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan <Arthur.Petrosyan@xxxxxxxxxxxx> wrote: > > To avoid working in two modes (partial power down > and hibernation) changed conditions for entering > partial power down or hibernation. > > Instead of checking hw_params.power_optimized and > hw_params.hibernation now checking power_down > param which already set to one of the options > (Hibernation or Partial Power Down) based on > OTG_EN_PWROPT. > > Signed-off-by: Artur Petrosyan <arturp@xxxxxxxxxxxx> > Signed-off-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx> > --- > drivers/usb/dwc2/core_intr.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) In general I'm in support of this patch--it's cleaner and gets rid of a needless goto \o/ ...but you don't go far enough. You can fully get rid of all of the "-ENOTSUPP" stuff. I've actually picked my patches and yours atop Felipe's "testing/next" tree and you can find it here: https://chromium.googlesource.com/chromiumos/third_party/kernel/+log/refs/sandbox/dianders/190426-dwc2-stuff ...as part of that I've included a patch ("usb: dwc2: Get rid of useless error checks for hibernation/partial power down"), AKA: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0c924f736e2f7c1bb02531aa33c04a3ae5f4fc4c Feel free to squash that into your patch or add it to your series if you like it. Note that patch points out that there's are still some instances where calling dwc2_exit_partial_power_down() might still happen in a case where it's not obvious if we were in partial power down mode and made me wonder if there might be some bugs there. -Doug
