Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 19, 2019 at 11:59 AM Marc Gonzalez <marc.w.gonzalez@xxxxxxx> wrote:
>
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>

The patch looks good, but please keep this in sync with the TI driver
that does the same thing, so better convert them both in one patch.

> ---
>  drivers/usb/dwc3/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
>  config USB_DWC3_QCOM
>         tristate "Qualcomm Platform"
> -       depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> +       depends on ARCH_QCOM || COMPILE_TEST
> +       depends on EXTCON || !EXTCON
>         depends on OF
>         default USB_DWC3
>         help
> --
> 2.17.1



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux