On Fri, Apr 19, 2019 at 01:24:23PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 19, 2019 at 11:59:08AM +0200, Marc Gonzalez wrote:
> > Keep EXTCON support optional, since some platforms do not need it.
> >
> > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
> > ---
> > drivers/usb/dwc3/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> > index 2b1494460d0c..6bd1a28c535f 100644
> > --- a/drivers/usb/dwc3/Kconfig
> > +++ b/drivers/usb/dwc3/Kconfig
> > @@ -115,7 +115,8 @@ config USB_DWC3_ST
> >
> > config USB_DWC3_QCOM
> > tristate "Qualcomm Platform"
> > - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> > + depends on ARCH_QCOM || COMPILE_TEST
> > + depends on EXTCON || !EXTCON
>
> Why is this last line needed? Does it really do anything?
As explained to me on irc, this line is fine.
Learn something new every day :)
greg k-h
