On 4/5/2019 5:36 PM, Jules Maselbas wrote: > Hi, > > Theses patches tries to clean a bit dwc2's phy initialization and > fix an issue in gadget mode where the utmi phy width is set > regardless of utmi being used or not. > > I believe that when using ulpi a phy width of 8 bits must be used, > but this wasn't the case as the variable phyif was set by default > to 16 bits. > > In this second patch-set version the last two patches are optionnal, > from my point of view they are not essential for me but I hope they > can improve this driver. > > Best regards, > Jules > --- > Changes in v2: > - Changed patches order > - dwc2_init_fs_ls_pclk_sel is now declared in core.h (to be used in hcd.c) > - Fix patch `Replace phyif with phy_utmi_width` (wrong value set to usbcfg) > - Add check for utmi phy type in patch `Replace phyif with phy_utmi_width` > > --- > Jules Maselbas (5): > usb: dwc2: Move UTMI_PHY_DATA defines closer > usb: dwc2: gadget: Remove duplicated phy init > usb: dwc2: gadget: Replace phyif with phy_utmi_width > usb: dwc2: Move phy init into core > usb: dwc2: gadget: Move gadget phy init into core phy init > > drivers/usb/dwc2/core.c | 199 ++++++++++++++++++++++++++++++++++++ > drivers/usb/dwc2/core.h | 4 +- > drivers/usb/dwc2/gadget.c | 36 ++----- > drivers/usb/dwc2/hcd.c | 190 ---------------------------------- > drivers/usb/dwc2/hw.h | 6 +- > drivers/usb/dwc2/platform.c | 5 +- > 6 files changed, 213 insertions(+), 227 deletions(-) > Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
