device_create_file() could fail and return an error code. The fix captures the error and returns the error code upstream in case it indeed failed. Signed-off-by: Kangjie Lu <kjlu@xxxxxxx> --- drivers/usb/storage/sierra_ms.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c index 6ac60abd2e15..2c049e3a56eb 100644 --- a/drivers/usb/storage/sierra_ms.c +++ b/drivers/usb/storage/sierra_ms.c @@ -195,6 +195,10 @@ int sierra_ms_init(struct us_data *us) } complete: result = device_create_file(&us->pusb_intf->dev, &dev_attr_truinst); + if (result) { + kfree(swocInfo); + return result; + } return 0; } -- 2.17.1