[PATCH] Add Unusual Dev for Sony GPS-CS1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Phil Endecott <sonygpsbug@xxxxxxxxxxxx>

Add an UNUSUAL_DEV for the Sony GPS-CS1 (054c:0298), which seems to suffer from 
the READ CAPACITY off-by-one and LOCKING bugs.

Signed-off-by: Phil Endecott <sonygpsbug@xxxxxxxxxxxx>
---
This device used to work for me without any fixes.  It now doesn't work even with 
older kernels.  I don't know why; my best guess is that perhaps it didn't need 
to look at the last sector until recently, maybe due to filesystem layout or 
something.  Because of my uncertainly I've made this a "guess capacity", not 
"fix capacity".

What is the normal policy for bcdDevice matching?  I have written this to
match only the version that I have.  I know nothing about any other versions.

The names I have used are the ones printed on the device; those reported in
the descriptors are less enlightening.  Is that right?

Here is an extract from /proc/bus/usb/devices:

T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=054c ProdID=0298 Rev= 1.00
S:  Manufacturer=Sony Corporation
S:  Product=Sony DI Accessory
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms

This patch is against a fairly-recent copy of Linus' tree.

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 4b8b690..fd35f8f 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -657,6 +657,13 @@ UNUSUAL_DEV(  0x054c, 0x016a, 0x0000, 0x9999,
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
+/* Submitted by Phil Endecott <sonygpsbug@xxxxxxxxxxxx> */
+UNUSUAL_DEV(  0x054c, 0x0298, 0x0100, 0x0100,
+		"Sony",
+		"GPS-CS1",
+		US_SC_DEVICE, US_PR_DEVICE, NULL,
+		US_FL_CAPACITY_HEURISTICS | US_FL_NOT_LOCKABLE ),
+
 /* floppy reports multiple luns */
 UNUSUAL_DEV(  0x055d, 0x2020, 0x0000, 0x0210,
 		"SAMSUNG",


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux