Re: [PATCH] usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 15, 2019 at 04:36:13PM +0200, Heikki Krogerus wrote:
> On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
> > Keep the orientation value when setting the mux to safe mode, this
> > fixes the orientation getting reset when switching alt-modes.
> > 
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> 
> Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Also applied to my typec-next branch:
https://github.com/krohei/linux/commit/4002f81b327b4537dead79ed6117dcb8065d2dca

> > ---
> >  drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> > index 64eb5983e17a..9294e85fd34b 100644
> > --- a/drivers/usb/typec/mux/pi3usb30532.c
> > +++ b/drivers/usb/typec/mux/pi3usb30532.c
> > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
> >  
> >  	switch (state) {
> >  	case TYPEC_STATE_SAFE:
> > -		new_conf = PI3USB30532_CONF_OPEN;
> > +		new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> > +			   PI3USB30532_CONF_OPEN;
> >  		break;
> >  	case TYPEC_STATE_USB:
> >  		new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> > -- 
> > 2.20.1

thanks,

-- 
heikki



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux