On Sun, Mar 17, 2019 at 10:36:03PM +0200, Andy Shevchenko wrote: > On Fri, Mar 15, 2019 at 6:58 PM Heikki Krogerus > <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > > > Software nodes provide two features that we will need later. > > 1) Software nodes can have references to other software nodes. > > 2) Software nodes can exist before a device entry is created. > > > > I don't see any problems with code (*), though I hope Hans will have > chance to test this. > One nit below. > > (*) Means all patches touching PDx86 in this series > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > --- > > drivers/platform/x86/intel_cht_int33fe.c | 122 +++++++++++++++++------ > > 1 file changed, 92 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c > > index 6fa3cced6f8e..26444d31945b 100644 > > --- a/drivers/platform/x86/intel_cht_int33fe.c > > +++ b/drivers/platform/x86/intel_cht_int33fe.c > > @@ -24,15 +24,25 @@ > > #include <linux/platform_device.h> > > #include <linux/regulator/consumer.h> > > #include <linux/slab.h> > > > +#include <linux/pci.h> > > Preserve the ordering, please. OK. thanks, -- heikki
