Hi Shimoda-San,
Thanks for the feedback.
> Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-
> switch property
>
> Hi Biju-san,
>
> > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM
> >
> > Add support for renesas_usb3 to support dual role switch using usb
> > role switch class framework.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > ---
> > V1-->V2
> > * Added usb-role-switch-property
> > * Updated the example with usb-role-switch property.
> > ---
> > .../devicetree/bindings/usb/renesas_usb3.txt | 22
> ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > index 35039e7..eecaf4c 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > @@ -22,6 +22,7 @@ Required properties:
> > Optional properties:
> > - phys: phandle + phy specifier pair
> > - phy-names: must be "usb"
> > + - usb-role-switch: use USB role switch to support dual-role switch
>
> I don't think we can add such a property. At least, we have to add "renesas,"
> prefix.
usb_role_switch_get api uses "usb-role-switch" property to get role switch linked with the device.
HD3SS3220 port controller driver gets role switch handle linked with the device using usb_role_switch_get api.
That is the reason, I have added " usb-role-switch" property here.
Do you have any other suggestion to get usb role switch handle?
Please correct me if I am wrong.
> > Example of R-Car H3 ES1.x:
> > usb3_peri0: usb@ee020000 {
> > @@ -39,3 +40,24 @@ Example of R-Car H3 ES1.x:
> > interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cpg CPG_MOD 327>;
> > };
> > +
> > +Example of RZ/G2E:
> > + usb3_peri0: usb@ee020000 {
> > + compatible = "renesas,r8a774c0-usb3-peri",
> > + "renesas,rcar-gen3-usb3-peri";
> > + reg = <0 0xee020000 0 0x400>;
> > + interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 328>;
> > + companion = <&xhci0>;
> > + usb-role-switch;
> > +
> > + port {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + usb3peri_role_switch: endpoint@0 {
> > + reg = <0>;
> > + remote-endpoint = <&hd3ss3220_ep>;
> > + };
> > + };
> > + };
> > --
> > 2.7.4
Regards,
Biju
