Re: [PATCH v2 8/8] usb: typec: fusb302: Add __printf attribute to fusb302_log function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 07, 2019 at 05:36:07PM +0100, Hans de Goede wrote:
> Add __printf attribute to fusb302_log function, so that we get
> compiler warnings when specifying wrong vararg parameters.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 6cdc38b8da74..ad1538c31dc8 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -125,13 +125,13 @@ struct fusb302_chip {
>   */
>  
>  #ifdef CONFIG_DEBUG_FS
> -
>  static bool fusb302_log_full(struct fusb302_chip *chip)
>  {
>  	return chip->logbuffer_tail ==
>  		(chip->logbuffer_head + 1) % LOG_BUFFER_ENTRIES;
>  }
>  
> +__printf(2, 0)
>  static void _fusb302_log(struct fusb302_chip *chip, const char *fmt,
>  			 va_list args)
>  {
> -- 
> 2.20.1
> 



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux