On Thu, Feb 28, 2019 at 05:34:25PM +0000, Måns Rullgård wrote:
> >> --- a/drivers/usb/core/hub.c
> >> +++ b/drivers/usb/core/hub.c
> >> @@ -2392,6 +2392,14 @@ static void set_usb_port_removable(struct usb_device *udev)
> >> break;
> >> }
> >>
> >> + /*
> >> + * Otherwise, check whether DT indicates this device is non-removable.
> >> + */
> >> + if (of_property_read_bool(udev->dev.of_node, "non-removable")) {
> >> + udev->removable = USB_DEVICE_FIXED;
> >> + return;
> >> + }
> >
> > Shouldn't this be an attribute of the USB hub's port, not the device
> > itself? That's the way it works with ACPI, and odds are any description
> > of USB devices in DT is also going to look much like how ACPI describes
> > the devices, let's not try to diverge when it is not necessary.
>
> Fine with me. That's why I asked.
>
> How about a non-removable-ports property in the hub node listing the
> hardwired ports?
Sounds reasonable to me as that should mirror what happens in ACPI, so
you should be able to just mirror what drivers/usb/core/usb-acpi.c does
for dt.
thanks,
greg k-h
