Hi > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: 2019年2月26日 15:25 > To: Jun Li <jun.li@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; hdegoede@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH 2/2] usb: typec: add typec switch via GPIO control > > On Mon, Feb 25, 2019 at 9:27 AM Jun Li <jun.li@xxxxxxx> wrote: > > > > This patch adds a simple typec switch driver which only needs a GPIO > > to switch the super speed active channel according to typec > > orientation. > > > +#include <linux/module.h> > > +#include <linux/mutex.h> > > +#include <linux/kernel.h> > > +#include <linux/platform_device.h> > > > +#include <linux/of.h> > > +#include <linux/of_gpio.h> > > I don't see how these are in use. I will use below 2 head files instead for v2. #include <linux/gpio/consumer.h> #include <linux/mod_devicetable.h> Thanks Li Jun > > -- > With Best Regards, > Andy Shevchenko
