Re: [PATCH v3 2/5] usb: gadget: u_serial: reimplement console support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 27, 2019 at 11:46:57AM +0100, Michał Mirosław wrote:
> Rewrite console support to fix a few shortcomings of the old code
> preventing its use with multiple ports. This removes some duplicated
> code and replaces a custom kthread with simpler workqueue item.
> 
> Only port ttyGS0 gets to be a console for now.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>

It's a tough chunk of code to review, but I _think_ it looks correct.
As long as you have actually tested it :)

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux