Re: [PATCH] usb: ehci: Cleanup itd/sidt_complete()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 25, 2019 at 05:41:45PM +0100, Greg KH wrote:
> On Tue, Feb 26, 2019 at 12:51:44AM +0900, Suwan Kim wrote:
> > This patch makes itd/sitd_complete() use *bus instead of referening
> > ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines.
> 
> That is two different things to do in the same patch, please break this
> up into different patches.

Sorry. I will break it up and send separate patches.

> And when you do, say _why_ you are making these changes, not just a
> description of the change itself.  We can read the patch to see what it
> does, but we do not know why you want to do this.
> 
> thanks,
> 
> greg k-h

Ok, you are right. My description is very short. I will rewrite the
description including why i do this and resend v2.

Regards

Suwan Kim



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux