On Fri, Feb 15, 2019 at 11:48:37AM +0530, Nagarjuna Kristam wrote:
>
>
> On 13-02-2019 12:34, Nagarjuna Kristam wrote:
> >>> EXPORT_SYMBOL_GPL(tegra_xusb_padctl_usb3_set_lfps_detect);
> >>>
> >>> +int tegra_xusb_padctl_set_vbus_override(struct tegra_xusb_padctl *padctl)
> >>> +{
> >>> + if (padctl->soc->ops->vbus_override)
> >>> + return padctl->soc->ops->vbus_override(padctl, true);
> >>> +
> >>> + return -EINVAL;
> >> It'd be best to stick to the -ENOSYS error code here.
> >>
> > will do
> >
> Using ENOSYS is marked as checkpatch warning
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>
> I suggest to use ENOTSUP instead of EINVAL/ENOSYS.
Sounds good to me.
Thierry
Attachment:
signature.asc
Description: PGP signature
