On Wed, Feb 20, 2019 at 12:27 PM Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> wrote: > > I'm taking a different approach, USB3 ports in polling state should > automatically move to connected/enabled. So instead of preventing > suspend if a port is found in polling I'll let it try to finish link > training for some time, and then just continue with suspend if it fails. > > Patch attached. > > This won't fix the broken card reader, but should allow your MacBook to suspend. > After this we can start looking at fixing the card reader, Ivan Miranov sent some > proposal for this. Hi Mathias, I tried the patch and it works for me. I do see the card reader still in polling, but, as you say, it does not prevent suspend. Personally, I never use the card reader so I'm ok with it not working. On resume I see the following messages printed but it doesn't appear to affect further suspend/resume sequences: Feb 21 19:59:13 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:13 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: hub 2-0:1.0: port_wait_reset: err = -16 Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not enabled, trying warm reset again... Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:14 eric-macbookpro kernel: hub 2-0:1.0: port_wait_reset: err = -16 Feb 21 19:59:14 eric-macbookpro kernel: usb usb2-port3: not enabled, trying warm reset again... Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:15 eric-macbookpro kernel: hub 2-0:1.0: port_wait_reset: err = -16 Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not enabled, trying warm reset again... Feb 21 19:59:15 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not warm reset yet, waiting 200ms Feb 21 19:59:16 eric-macbookpro kernel: xhci_hcd 0000:00:14.0: CTRL: TypeReq=0x2303 val=0x5 idx=0x303 len=0 ==> -19 Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: status 0341, change 0000, 5.0 Gb/s Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not reset yet, waiting 60ms Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not reset yet, waiting 200ms Feb 21 19:59:16 eric-macbookpro kernel: usb usb2-port3: not reset yet, waiting 200ms Feb 21 19:59:17 eric-macbookpro kernel: usb usb2-port3: not reset yet, waiting 200ms Feb 21 19:59:17 eric-macbookpro kernel: usb usb2-port3: not reset yet, waiting 200ms Feb 21 19:59:17 eric-macbookpro kernel: xhci_hcd 0000:00:14.0: CTRL: TypeReq=0x2303 val=0x5 idx=0x303 len=0 ==> -19 Feb 21 19:59:17 eric-macbookpro kernel: xhci_hcd 0000:00:14.0: CTRL: TypeReq=0x2303 val=0x5 idx=0x303 len=0 ==> -19 Feb 21 19:59:17 eric-macbookpro kernel: hub 2-0:1.0: state 7 ports 4 chg 0000 evt 0008 Feb 21 19:59:17 eric-macbookpro kernel: hub 2-0:1.0: hub_suspend Feb 21 19:59:17 eric-macbookpro kernel: usb usb2: bus auto-suspend, wakeup 1 Thanks, Eric
