Hi, On Tue, Feb 12, 2019 at 10:41:28AM +0000, Jun Li wrote: > > @@ -32,6 +32,7 @@ typedef enum usb_role (*usb_role_switch_get_t)(struct > > device *dev); > > * usb_role_switch_register() before registering the switch. > > */ > > struct usb_role_switch_desc { > > + struct fwnode_handle *fwnode; > You may add some description for this new member > /** > * struct usb_role_switch_desc - USB Role Switch Descriptor > * @ fwnode You are correct. I need to fix that one. thanks, -- heikki