Hello Eric, thanks for the fast reply & great to hear the issue is pinpointed to a single commit! Much appreciated. Can I help in any way to get this fixed? Greetings, Selwyn. On 11-02-19 15:15, Eric Blau wrote: > On Mon, Feb 11, 2019 at 8:45 AM Selwyn <talk@xxxxxxxxx> wrote: >> Hope I'm doing this right, following https://wiki.ubuntu.com/Bugs/Upstream/kernel and Christopher M. Penalver's suggestion to email to Mathias Nyman and Greg Kroah-Hartman. >> >> [1.] One line summary of the problem: >> Kernel fails to suspend on Macbook Pro 2015 probably due to usb2. >> >> [2.] Full description of the problem/report: >> The first time suspending works great but after that suspending causes the laptop to wake up regardless of the method used to suspend. >> 2a. Suspend the system (`systemctl suspend`), wake up, suspend for a second time, the system will immediately wake up again. >> 2b. I don't know if this is a regression. > Hi Selwyn, > > I have the exact same laptop and have been hitting the same regression > since after I upgraded from 4.19.4 to 4.19.8. I've been working > through this issue with Mathias and providing some additional > debugging info. I've tracked down the commit that introduced the > regression. Reverting the commit solves the problem for me: > > commit cc8b329fef53c74a4abf98b0755b3832d572d6ce > Author: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > Date: Thu Nov 15 11:38:41 2018 +0200 > > usb: xhci: Prevent bus suspend if a port connect change or polling > state is detected > > commit 2f31a67f01a8beb22cae754c53522cb61a005750 upstream. > > > See the thread here: > > https://marc.info/?l=linux-usb&m=154915973623396&w=2 > > Could this commit possibly be reverted in the -stable series? > > Regards, > Eric
