On Wed, 2009-05-06 at 00:04 -0700, Oliver Neukum wrote:
> Am Mittwoch, 6. Mai 2009 01:25:42 schrieb Elina Pasheva:
> > +static int sierra_submit_rx_urbs(struct usb_serial_port *port)
> > +{
> > + int ok_cnt;
> > + int err = -EINVAL;
> > + int i;
> > + struct urb *urb;
> > + struct sierra_port_private *portdata =
> > usb_get_serial_port_data(port); +
> > + ok_cnt = 0;
> > + for (i = 0; i < ARRAY_SIZE(portdata->in_urbs); i++) {
> > + urb = portdata->in_urbs[i];
> > + if (!urb)
> > + continue;
> > + err = usb_submit_urb(urb, GFP_KERNEL);
>
> This rules out using this function in post_reset() and resume(). It would be
> optimal, if you added a second parameter to pass the memory allocation
> parameter.
>
> Regards
> Oliver
>
Thank you Oliver for the good point. I will add a second parameter to
pass the memory allocation parameter to sierra_submit_rx_urbs(). Then I
will re-do the rest of the patches in the series (from 003/008 to
008/008) to reflect the change.
Regards,
Elina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
