On Wed, Jan 23, 2019 at 9:13 AM Eric Blau <eblau@xxxxxxxxx> wrote: > > On Tue, Jan 22, 2019 at 2:28 PM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > > > In the absence of any better suggestions, you can always try using git > > bisect between 4.19.4 and 4.19.8. The amount of churn ought to be > > relatively small, so it shouldn't take too long to home in on the > > commit which caused the problem. > > > > Also, you should provide a little more information about your system in > > your bug report. For example, the output from "lsusb". > > Thanks, Alan. I'll try a bisect but I'm running a ZFS root filesystem > which is out-of-tree so it's a pain to rebuild and install the ZFS > modules after every bisect as well. I'll see what I can do. > > Here's lsusb: > > Bus 002 Device 002: ID 05ac:8406 Apple, Inc. > Bus 002 Device 005: ID 0424:5537 Standard Microsystems Corp. > Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub > Bus 001 Device 003: ID 05ac:0273 Apple, Inc. Internal Keyboard/Trackpad (ISO) > Bus 001 Device 002: ID 05ac:8290 Apple, Inc. Bluetooth Host Controller > Bus 001 Device 014: ID 05ac:1402 Apple, Inc. Ethernet Adapter [A1277] > Bus 001 Device 018: ID 062a:4102 MosArt Semiconductor Corp. > Bus 001 Device 017: ID 05e3:0608 Genesys Logic, Inc. Hub > Bus 001 Device 016: ID 04d9:2013 Holtek Semiconductor, Inc. Keyboard > [Das Keyboard] > Bus 001 Device 015: ID 0424:2137 Standard Microsystems Corp. > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > I've not narrowed down the exact trigger for the problem as it seems > intermittent. If I have any more insight, I'll share it. I finally was able to complete the bisect on this issue. It seems that this commit introduced the regression on my MacBook Pro: cc8b329fef53c74a4abf98b0755b3832d572d6ce is the first bad commit commit cc8b329fef53c74a4abf98b0755b3832d572d6ce Author: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> Date: Thu Nov 15 11:38:41 2018 +0200 usb: xhci: Prevent bus suspend if a port connect change or polling state is detected commit 2f31a67f01a8beb22cae754c53522cb61a005750 upstream. As reported earlier, with this commit, my laptop fails to suspend with the following errors: Feb 02 17:56:43 eric-macbookpro kernel: dpm_run_callback(): usb_dev_suspend+0x0/0x10 returns -16 Feb 02 17:56:43 eric-macbookpro kernel: PM: Device usb2 failed to suspend async: error -16 Feb 02 17:56:43 eric-macbookpro kernel: PM: Some devices failed to suspend, or early wake event detected I also occasionally see a ksoftirqd and kworker thread/process together taking up 100% of one core. Regards, Eric