Re: [PATCH 03/18] net: caif: pass struct device to DMA API functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Robin Murphy <robin.murphy@xxxxxxx>
Subject: Re: [PATCH 03/18] net: caif: pass struct device to DMA API functions
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 1 Feb 2019 17:10:45 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, John Crispin <john@xxxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Dmitry Tarnyagin <dmitry.tarnyagin@xxxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>, Felipe Balbi <balbi@xxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <1cafba51-b652-5457-0dd7-77d64264c85e@arm.com>
References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-4-hch@lst.de> <1cafba51-b652-5457-0dd7-77d64264c85e@arm.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Fri, Feb 01, 2019 at 01:53:09PM +0000, Robin Murphy wrote:
>>   #define LOW_WATER_MARK   100
>>   #define HIGH_WATER_MARK  (LOW_WATER_MARK*5)
>>   -#ifdef CONFIG_UML
>> +#ifdef CONFIG_HAS_DMA
>
> #ifndef, surely?

Indeed.

References:
- don't pass a NULL struct device to DMA API functions
  - From: Christoph Hellwig
- [PATCH 03/18] net: caif: pass struct device to DMA API functions
  - From: Christoph Hellwig
- Re: [PATCH 03/18] net: caif: pass struct device to DMA API functions
  - From: Robin Murphy

Prev by Date: Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
Next by Date: Re: [PATCH 10/18] smc911x: pass struct device to DMA API functions
Previous by thread: Re: [PATCH 03/18] net: caif: pass struct device to DMA API functions
Next by thread: [PATCH 04/18] au1000_eth: pass struct device to DMA API functions
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]