Hi, "He, Bo" <bo.he@xxxxxxxxx> writes: > agree your findings. > > so it's better move the synchronize_irq() after the spin_unlock_irqrestore(). > static int dwc3_suspend_common(struct dwc3 *dwc) > { > unsigned long flags; > > switch (dwc->dr_mode) { > case USB_DR_MODE_PERIPHERAL: > case USB_DR_MODE_OTG: > spin_lock_irqsave(&dwc->lock, flags); > dwc3_gadget_suspend(dwc); > spin_unlock_irqrestore(&dwc->lock, flags); > synchronize_irq() indeed, I missed that when I first reviewed the patch. Care to send a fix? -- balbi
Attachment:
signature.asc
Description: PGP signature