On Fri, Jan 25, 2019 at 3:18 PM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> We can replace the second parameter that is passed to the
> typec_mux_get() function with alt mode description
> structure, and simply pass NULL with accessory modes.
>
> With accessory modes there is no need for additional
> identification (in practice the accessory mode can only be
> Audio Accessory if muxing is needed), only with alternate
> modes we need to identify the exact alternate mode.
> +struct typec_mux *typec_mux_get(struct device *dev,
> + const struct typec_altmode_desc *desc)
> {
> struct typec_mux *mux;
>
> mutex_lock(&mux_lock);
> - mux = device_connection_find_match(dev, name, NULL, typec_mux_match);
> + mux = device_connection_find_match(dev, "typec-mux", (void *)desc,
> + typec_mux_match);
Not related to this series, but shouldn't
device_connection_find_match() be improved to avoid dropping const
qualifier?
--
With Best Regards,
Andy Shevchenko
