Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each release candidate, and I found a single instance (out of 2794 runs) of this warning on the Lenovo Yoga 920 with linux 5.0.0-rc2 running S3 suspend/resume. I noticed a similar issue in bugzilla and you commented that these issues should be sent out over the mailing list instead, thus I'm sending this via mail. I've attached the full sleepgraph timeline to the mail, but it might not make it through the mailing list. Full sleepgraph timeline is here (dmesg snippet below): https://01org.github.io/pm-graph/suspend-190120-174105/otcpl-yoga-920-k blr_mem.html Can you describe what is happening here? It seems the usb 3.0 host controller is failing, but I'm not completely sure how. SYSTEM INFO: baseboard-manufacturer : LENOVO baseboard-product-name : LNVNB161216 baseboard-serial-number : PF0W64WL baseboard-version : SDK0J40709 WIN bios-release-date : 02/22/2018 bios-vendor : LENOVO bios-version : 5NCN38WW chassis-manufacturer : LENOVO chassis-serial-number : PF0W64WL chassis-version : Lenovo YOGA 920-13IKB processor-manufacturer : Intel(R) Corporation processor-version : Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz system-manufacturer : LENOVO system-product-name : 80Y7 system-serial-number : PF0W64WL system-version : Lenovo YOGA 920-13IKB cpucount : 8 memtotal : 7973508 kB memfree : 6186476 kB $ lspci 00:14.0 USB controller: Intel Corporation Sunrise Point-LP USB 3.0 xHCI Controller (rev 21) $ lsusb -t /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p, 5000M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/12p, 480M |__ Port 1: Dev 2, If 1, Class=Video, Driver=uvcvideo, 480M |__ Port 1: Dev 2, If 0, Class=Video, Driver=uvcvideo, 480M |__ Port 5: Dev 3, If 0, Class=Vendor Specific Class, Driver=, 12M |__ Port 7: Dev 4, If 0, Class=Vendor Specific Class, Driver=asix, 480M |__ Port 8: Dev 5, If 1, Class=Wireless, Driver=btusb, 12M |__ Port 8: Dev 5, If 0, Class=Wireless, Driver=btusb, 12M DMESG SNIPPET: [ 29.873477] usb usb1: calling usb_dev_resume+0x0/0x20 @ 1828, parent: 0000:00:14.0 [ 29.873614] xhci_hcd 0000:38:00.0: remove, state 4 [ 29.873619] usb usb4: USB disconnect, device number 1 [ 29.873749] xhci_hcd 0000:38:00.0: USB bus 4 deregistered [ 29.873752] xhci_hcd 0000:38:00.0: remove, state 4 [ 29.873755] usb usb3: USB disconnect, device number 1 [ 29.873996] xhci_hcd 0000:38:00.0: Host halt failed, -19 [ 29.874006] xhci_hcd 0000:38:00.0: Host not accessible, reset failed. [ 29.874382] xhci_hcd 0000:38:00.0: USB bus 3 deregistered [ 29.874417] ------------[ cut here ]------------ [ 29.874420] xhci_hcd 0000:38:00.0: disabling already-disabled device [ 29.874528] WARNING: CPU: 0 PID: 169 at drivers/pci/pci.c:1870 pci_disable_device+0x9c/0xc0 [ 29.874530] Modules linked in: hid_sensor_accel_3d hid_sensor_als hid_sensor_trigger industrialio_triggered_buffer kfifo_buf hid_sensor_iio_common industrialio hid_sensor_custom joydev wacom usbhid hid_multitouch hid_sensor_hub thunderbolt rfcomm hid_generic 8250_dw arc4 bnep intel_rapl x86_pkg_temp_thermal nls_iso8859_1 intel_powerclamp coretemp snd_hda_codec_hdmi kvm_intel kvm irqbypass snd_soc_skl snd_soc_skl_ipc snd_soc_sst_ipc snd_soc_sst_dsp snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi snd_soc_core snd_hda_codec_realtek snd_hda_codec_generic snd_compress ledtrig_audio ac97_bus snd_pcm_dmaengine crct10dif_pclmul snd_hda_intel crc32_pclmul snd_hda_codec snd_hda_core ghash_clmulni_intel snd_hwdep snd_pcm snd_seq_midi snd_seq_midi_event ath10k_pci snd_rawmidi ath10k_core snd_seq uvcvideo snd_seq_device ath snd_timer aesni_intel btusb btrtl btbcm mac80211 videobuf2_vmalloc btintel videobuf2_memops videobuf2_v4l2 bluetooth aes_x86_64 videobuf2_common crypto_simd cryptd [ 29.874669] glue_helper snd videodev asix usbnet intel_cstate media mii input_leds ucsi_acpi intel_rapl_perf typec_ucsi cfg80211 ecdh_generic soundcore serio_raw typec wmi_bmof intel_wmi_thunderbolt ideapad_laptop int3403_thermal sparse_keymap idma64 virt_dma mei_me processor_thermal_device int340x_thermal_zone mei intel_soc_dts_iosf int3400_thermal mac_hid acpi_pad intel_lpss_pci acpi_thermal_rel intel_pch_thermal intel_lpss sch_fq_codel parport_pc ppdev lp parport ip_tables x_tables autofs4 i2c_i801 i2c_hid hid wmi [ 29.874751] CPU: 0 PID: 169 Comm: irq/122-pciehp Tainted: G U 5.0.0-rc2 #1 [ 29.874752] Hardware name: LENOVO 80Y7/LNVNB161216, BIOS 5NCN38WW 02/22/2018 [ 29.874758] RIP: 0010:pci_disable_device+0x9c/0xc0 [ 29.874762] Code: c6 05 52 2d 2f 01 01 4d 85 e4 74 36 48 8d bb b0 00 00 00 e8 16 b0 2c 00 4c 89 e2 48 89 c6 48 c7 c7 40 0c 99 86 e8 b4 a8 b6 ff <0f> 0b eb 82 48 89 df e8 d8 fe ff ff 80 a3 f1 07 00 00 fb 5b 41 5c [ 29.874764] RSP: 0018:ffffa64d811e7c40 EFLAGS: 00010286 [ 29.874766] RAX: 0000000000000000 RBX: ffff93cf689ca000 RCX: 0000000000000000 [ 29.874767] RDX: 0000000000000038 RSI: ffffffff871758d8 RDI: 0000000000000246 [ 29.874769] RBP: ffffa64d811e7c50 R08: 0000000000000000 R09: ffffffff871758a0 [ 29.874769] R10: ffffa64d811e7bf0 R11: 0000000000000e3d R12: ffff93cf65a401e0 [ 29.874770] R13: ffffffff86dcd7e0 R14: ffffffff86dcd850 R15: 0000000000000060 [ 29.874773] FS: 0000000000000000(0000) GS:ffff93cf77c00000(0000) knlGS:0000000000000000 [ 29.874774] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 29.874775] CR2: 00007f7bb79969d0 CR3: 000000022f00e002 CR4: 00000000003606f0 [ 29.874778] Call Trace: [ 29.874803] usb_hcd_pci_remove+0xcf/0x130 [ 29.874819] xhci_pci_remove+0x7f/0xa0 [ 29.874823] pci_device_remove+0x3e/0xc0 [ 29.874830] device_release_driver_internal+0x18d/0x250 [ 29.874831] device_release_driver+0x12/0x20 [ 29.874833] pci_stop_bus_device+0x68/0x90 [ 29.874834] pci_stop_bus_device+0x30/0x90 [ 29.874835] pci_stop_bus_device+0x42/0x90 [ 29.874836] pci_stop_and_remove_bus_device+0x12/0x20 [ 29.874846] pciehp_unconfigure_device+0x88/0x140 [ 29.874848] pciehp_disable_slot+0x6a/0x110 [ 29.874849] pciehp_handle_presence_or_link_change+0x76/0x420 [ 29.874853] pciehp_ist+0x1a7/0x1d0 [ 29.874872] ? irq_finalize_oneshot.part.43+0xf0/0xf0 [ 29.874873] irq_thread_fn+0x26/0x60 [ 29.874875] irq_thread+0xea/0x170 [ 29.874876] ? irq_forced_thread_fn+0x80/0x80 [ 29.874890] kthread+0x121/0x140 [ 29.874891] ? irq_thread_check_affinity+0xf0/0xf0 [ 29.874892] ? kthread_park+0x90/0x90 [ 29.874913] ret_from_fork+0x35/0x40 [ 29.874915] ---[ end trace 76dd906b4b33836d ]--- [ 29.875822] usb usb2: calling usb_dev_resume+0x0/0x20 @ 1818, parent: 0000:00:14.0 [ 29.875961] usb usb2: usb_dev_resume+0x0/0x20 returned 0 after 131 usecs
