Hi Greg -off-by: Ajay Gupta <ajayg@xxxxxxxxxx> > > --- > > drivers/usb/typec/ucsi/ucsi_ccg.c | 139 > > ++++++++++++++++++++++++++++++ > > 1 file changed, 139 insertions(+) > > > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c > > b/drivers/usb/typec/ucsi/ucsi_ccg.c > > index 5f341934a5af..6069a9f60d1e 100644 > > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > > @@ -9,6 +9,7 @@ > > */ > > #include <linux/acpi.h> > > #include <linux/delay.h> > > +#include <linux/firmware.h> > > #include <linux/i2c.h> > > #include <linux/module.h> > > #include <linux/pci.h> > > @@ -17,6 +18,8 @@ > > #include <asm/unaligned.h> > > #include "ucsi.h" > > > > +static int secondary_fw_min_ver = 41; > > +module_param(secondary_fw_min_ver, int, 0660); > > Ick, never add new module parameters, this isn't the 1990's :) Ok 😊 > nvpublic
