On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote: > Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there > are no more hidden accesses to local variables (vc_data and > sisusb_usb_data). > > sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is > what every caller expects -- we can remove some casts. > > Call sites were aligned to be readable too. > > Use sisusb_haddr on 4 more places in sisusbcon_blank and > sisusbcon_scroll. It was open coded there with [x, y] being [0, 0]. > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > --- > drivers/usb/misc/sisusbvga/sisusb_con.c | 78 ++++++++++++------------- > 1 file changed, 39 insertions(+), 39 deletions(-) Subject says "tty", yet this is the USB driver. typo? thanks, greg k-h