Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

To: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>, valentina.manea.m@xxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path
From: shuah <shuah@xxxxxxxxxx>
Date: Sun, 20 Jan 2019 12:29:19 -0700
Cc: linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, shuah <shuah@xxxxxxxxxx>
In-reply-to: <bf3e3361-2cab-3229-21a0-b4b12241afaa@cogentembedded.com>
References: <20190118212931.18482-1-skhan@linuxfoundation.org> <20190118212931.18482-2-skhan@linuxfoundation.org> <bf3e3361-2cab-3229-21a0-b4b12241afaa@cogentembedded.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 1/19/19 9:58 AM, Sergei Shtylyov wrote:

Hello!

On 01/19/2019 12:29 AM, Shuah Khan wrote:

From: Shuah Khan <shuah@xxxxxxxxxx>

Fix vhci_urb_enqueue() to print error and return error instead of
failing with WARN_ON.


    It's BUG_ON().


Thanks. I will fix it.

-- Shuah

References:
- [PATCH] usbip: Fix vep_free_request() null pointer checks on input args
  - From: Shuah Khan
- [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path
  - From: Shuah Khan
- Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path
  - From: Sergei Shtylyov