Re: [PATCH] USB: serial: keyspan_usa: add proper SPDX lines for .h files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 18, 2019 at 12:09:16PM +0100, Johan Hovold wrote:
> On Thu, Jan 17, 2019 at 09:23:46AM +0100, Greg Kroah-Hartman wrote:
> > The keyspan_usa??msg.h files are under a BSD-3 style license, so
> > properly label them as such with a SPDX line at the top of the file.
> > 
> > Cc: Johan Hovold <johan@xxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/serial/keyspan_usa26msg.h | 1 +
> >  drivers/usb/serial/keyspan_usa28msg.h | 1 +
> >  drivers/usb/serial/keyspan_usa49msg.h | 1 +
> >  drivers/usb/serial/keyspan_usa67msg.h | 1 +
> >  drivers/usb/serial/keyspan_usa90msg.h | 1 +
> >  5 files changed, 5 insertions(+)
> > 
> > diff --git a/drivers/usb/serial/keyspan_usa26msg.h b/drivers/usb/serial/keyspan_usa26msg.h
> > index 09e21e84fc4e..a68f1fb25b8a 100644
> > --- a/drivers/usb/serial/keyspan_usa26msg.h
> > +++ b/drivers/usb/serial/keyspan_usa26msg.h
> > @@ -1,3 +1,4 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause */
> 
> Actually, all but the keyspan_usa67msg.h appear to use a modified
> BSD-3-Clause with the second (binary-distribution) clause removed.
> 
> I assume you're aware of this and that the BSD-3-Clause identifier is
> still applicable. Just thought I'd mention it.

Yeah, I saw that, it's kind of the 2-clause, but there are 3 clauses in
it :)

The intent is for it to be 3 clause from what I can tell and what I
remember.  The goal was to allow the BSDs to be able to use the header
file in their kernels, and they did, so all was good.  I don't think the
company is around anymore, so I doubt it really matters.

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux