Re: [PATCH 2/7] usb: typec: ucsi: add ccg command framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 17, 2019 at 05:09:04PM -0800, Ajay Gupta wrote:
> Used to send command to ccg controller

Writing changelog comments is hard, but please do more than just tiny
snippets like this.  Explain _why_ this change is needed in detail
please.

Same for all of these patches, you are adding new functionality to the
kernel, I think it deserves more than one sentance or less per commit,
don't you?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux