Hello! On 01/17/2019 10:15 AM, min.guo@xxxxxxxxxxxx wrote: > From: Min Guo <min.guo@xxxxxxxxxxxx> > > This adds support for MediaTek musb controller in > host, peripheral and otg mode. > > Signed-off-by: Min Guo <min.guo@xxxxxxxxxxxx> > --- > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > new file mode 100644 > index 0000000..3e3f671 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > @@ -0,0 +1,43 @@ > +MediaTek musb DRD/OTG controller > +------------------------------------------- > + > +Required properties: > + - compatible : should be "mediatek,mtk-musb" > + - reg : specifies physical base address and size of > + the registers I'd indent it more to align with "specifies", else it looks weird. > + - interrupts : interrupt used by musb controller > + - interrupt-names : must be "mc" > + - phys : PHY specifier for the OTG phy > + - dr_mode : should be one of "host", "peripheral" or "otg", > + refer to usb/generic.txt Same here... > + - clocks : a list of phandle + clock-specifier pairs, one for > + each entry in clock-names Here... > + - clock-names : must contain "main", "mcu", "univpll" > + for clocks of controller And here. > + > +Optional properties: > + - extcon : external connector for VBUS and IDPIN changes detection, ID pin, maybe? > + needed when supports dual-role mode. > + - vbus-supply : reference to the VBUS regulator, needed when supports > + dual-role mode. > + - power-domains : a phandle to USB power domain node to control USB's > + MTCMOS [...] MBR, Sergei
