Hi Johan, Please add a space after each colon in the commit summary (subject) and no need to capitalise "serial". Charles_Ans: OK... Is this one independent of the second "pull-up" patch? Charles_Ans: Yes, it is independent of the second "pull-up" patch. Charles Yeh(葉榮鑫) TeL: +886-2-26546363 ext.522 Prolific Technology Inc. (旺玖科技股份有限公司) -----Original Message----- From: Johan Hovold [mailto:johan@xxxxxxxxxx] Sent: Wednesday, January 16, 2019 7:22 PM To: Charles Yeh Cc: gregkh@xxxxxxxxxxxxxxxxxxx; johan@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Yeh.Charles [葉榮鑫] Subject: Re: [PATCH] USB:Serial:pl2303:Add new PID to support PL2303TB(TYPE_HX) Please add a space after each colon in the commit summary (subject) and no need to capitalise "serial". On Tue, Jan 15, 2019 at 11:13:56PM +0800, Charles Yeh wrote: > Add new PID to support PL2303TB (TYPE_HX) Is this one independent of the second "pull-up" patch? > Signed-off-by: Charles Yeh <charlesyeh522@xxxxxxxxx> Thanks, Johan 保密警語: 本電子郵件內容及其附加檔案均視為機密資料,受保密合約保護或依法不得洩漏。其內容僅供指定收件人按限定範圍或特殊目的合法使用,未經授權者收到此信息均無權閱讀、使用、複製、洩漏或散佈。若您並非本郵件之指定收件人,請即刻回覆郵件並永久刪除此郵件及其附件和銷毀所有複印文件。電子郵件的傳輸可能遭攔截、損毀、遺失、破壞、遲到或不完整、或包含病毒,無法保證其安全或無誤。寄件人不承擔因本電子郵件的錯誤或遺漏所產生的任何損害賠償責任。 Confidentiality Notice: This e-mail message together with any attachments thereto (if any) is confidential, protected under an enforceable non-disclosure agreement, intended only for the use of the named recipient(s) above and may contain information that is privileged, belonging to professional work products or exempt from disclosure under applicable laws. Any unauthorized review, use, copying, disclosure, or distribution of any information contained in or attached to this transmission is strictly prohibited and may be against the laws. If you have received this message in error, or are not the intended recipient(s), please immediately notify the sender by e-mail and delete this e-mail message, all copies, and any attached documentation from your computer. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any damage caused by any errors or omissions in the contents of this email.