On 1/3/19 2:28 PM, Andrew Lunn wrote: > On Thu, Jan 03, 2019 at 02:10:33AM +0100, Marek Vasut wrote: >> Replace the ad-hoc reimplementation of genphy_soft_reset() and >> genphy_config_aneg() with the generic functions. > > phylib will either call the phy driver specific reset function, or > genphy_soft_reset. The same is also true for configuring > auto-neg. Please just kill this code and leave the PHY driver to do > its job. In this patch or subsequent ? I think we should do that in a subsequent patch, to keep this bisectable in case something breaks. -- Best regards, Marek Vasut
