Haavard Skinnemoen wrote: > David Brownell wrote: > > On Friday 01 May 2009, Martin Fuzzey wrote: > > > usbtest #14 was failing with "udc: ep0: TXCOMP: Invalid endpoint state 2, halting endpoint..." > > > This occured since ep0 is bidirectional and ep->is_in is not valid (must always use ep->state) > > > > > > Signed-off-by: Martin Fuzzey <mfuzzey@xxxxxxxxx> > > > > Cool... worked for me too. Haavard, any comments? > > Yes, it makes lots of sense. Btw, I think the real problem is that the is_in field is uninitialized in the first place. I'll follow up with another patch fixing that and other potential issues with uninitialized fields. I still think this patch makes sense because the is_in field doesn't have a clearly defined meaning for control endpoints, so we shouldn't rely on it always being 0 for control endpoints (especially since it really _is_ undefined in the current driver). Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
