* Roger Quadros <rogerq@xxxxxx> [181213 12:09]: > Tony, > > On 13/12/18 04:17, Tony Lindgren wrote: > > The only case where we can bail out safely without a phy is port_mode > > is OMAP_USBHS_PORT_MODE_UNUSED. It used to be that OMAP_EHCI_PORT_MODE_PHY > > was optional, but that's not a good assumption. We should already have > > "ehci-phy" in all the dts files using OMAP_EHCI_PORT_MODE_PHY. > > > > We don't use the PHY at all if port mode is not OMAP_EHCI_PORT_MODE_PHY. Hmm thanks for looking. That logic seems like it was valid something like 10 years ago for omap3, I don't think that applies any longer. We see -EPROBE_DEFER errors for OMAP_EHCI_PORT_MODE_HSIC on omap5-uevm for SMSC Ethernet. So that's with "ehci-hsic" in the dts files. > What issue is this patch fixing? We ignore -EPROBE_DEFER errors now. That's reproducable with current Linux next on omap5-uevm with phy-generic, ehci-omap and smsc Ethernet built-in. After boot ifconfig -a won't show eth0. Care to recheck what the safe logic to ignore errors can be? Regards, Tony
