Hi Bjorn, On 12/10/2018 10:49 AM, Bjorn Helgaas wrote: > On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: >> Move Synopsys HAPS platform device IDs to pci_ids.h. >> >> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> > 1) Run "git log --oneline include/linux/pci_ids.h" and follow the > style convention for patch subject. > > 2) Explain in the changelog why we're moving this to pci_ids.h. Note > the comment at the top of pci_ids.h. I think the move is fine because > you're using the definition in two places, so just mention that in the > changelog. > > Thanks! Thanks for the review! I'll fix it. Thinh
