On Sunday 03 May 2009, Oliver Neukum wrote:
> Please comment and test.
No testing just yet -- I'd want a cdc-ether device that's
configured to support WOL and remote wakeup, and the gadget
stack doesn't do that right now.
A quick read doesn't raise questions beyond checkpatch.pl
failures, though I'd ask you to change the
if (!...) {
...
} else {
...
}
to remove the "!". As a rule, testing on negatives turns
code flow confusing so I discourage it. Add unlikely()
if you prefer.
Oh, and please cc netdev on usbnet and framework patches.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
