Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 9 Dec 2018 17:32:45 +0100

> +	} else {
>  		port_spec = hso_get_config_data(interface);
> +		if (IS_ERR_VALUE((long)port_spec))
> +			goto exit;

'port_spec' is an 'int', it makes no sense to cast it 3 times all the
way back to 'int' to figure out if it is a negative error value or
not. (--> long --> void * --> int)



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux