On Fri, 23 Nov 2018 at 13:21, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote: > > > > Hi Ulf, > > > > > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> wrote: > > > > > >> This is based on Ulf's work [1] [2]. > > >> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel > > >> platforms and ~1.5W on AMD platforms. > > >> [1] https://patchwork.kernel.org/patch/10440583/ > > >> [2] https://patchwork.kernel.org/patch/10445725/ > > > > > > Tested-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> > > > > Do you think this series is ready to be merged to v4.20? > > I have had a brief look at the latest version a while ago, looked > good. However, allow a few more days before I can give it my final > blessing. > > BTW. We need to figure out what path to route the changes through. I > can pick it via my mmc tree, unless someone object to that. Okay, so I have picked up the patches and applied them to my next branch to my mmc tree. While doing that, I have also added Oleksandr's tested-by tag for all patches, including the four mmc patches. I also added your tested-by tags to the the four mmc patches. Finally I made little cosmetic change to last patch in this series, which was dropping the surrounding #ifdef CONFIG_PM while do the assignment of .driver.pm to &rtsx_usb_ms_pm_ops, as that isn't needed. If anybody have any objections, please tell me. Kind regards Uffe