Re: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Anurag Kumar Vulisha <anurag.kumar.vulisha@xxxxxxxxxx> writes:
> @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
>  	}
>  
>  	switch (event->endpoint_event) {
> +	case DWC3_DEPEVT_XFERCOMPLETE:
> +		if (!dep->stream_capable)
> +			break;
> +		dep->flags &= ~DWC3_EP_TRANSFER_STARTED;
> +		/* Fall Through */

instead, let's add a proper handler for this:

dwc3_gadget_endpoint_transfer_complete(dep, event);

That handler should be "self-sufficient". IOW, we shouldn't have this
fall through here. This means that the other patch where you modify
dwc3_gadget_transfer_in_progress() shouldn't be necessary, since that
event shouldn't run for stream capable endpoints.

While rewriting the patches, please rebase on my testing/next as I have
applied a few of the patches in this series.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux