On Wed, Dec 5, 2018 at 3:57 AM Chen Yu <chenyu56@xxxxxxxxxx> wrote: > On 2018/12/5 1:47, Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu <chenyu56@xxxxxxxxxx> wrote: > >> On 2018/12/3 17:23, Andy Shevchenko wrote: > >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@xxxxxxxxxx> wrote: > > > >>>> + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), > >>> > >>> Does it compiles for non-OF case? Why macro is in use? > > > >> OK. I will add the "CONFIG_OF". > > Why? Is this driver supposed to work without DT? > > > No. This driver should depend on OF. > Can I solve this by add "dpends on OF" in Kconfig? Yes and don't forget to drop unneeded macro(s) like of_match_ptr() above. -- With Best Regards, Andy Shevchenko