Subject: [PATCH 002/004] USB: serial: sierra driver interrupt urb resubmit fix
From: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx>
The following is summary of changes we have made to sierra.c driver in
[PATCH 002/004] dealing with interrupt urb resubmit fix:
- Fixed a problem when re-submitting urb from interrupt callback in function
sierra_instat_callback(). This suppresses also issuing of error messages in
/var/log/kern.log
- Removed redundant debug message at the beginning of sierra_instat_callback()
function
- Changed a debug message to be an error message
Signed-off-by: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx>
---
drivers/usb/serial/sierra.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/usb/serial/sierra.c 2009-04-30 18:33:37.000000000 -0700
+++ b/drivers/usb/serial/sierra.c 2009-05-01 11:20:02.000000000 -0700
@@ -507,7 +507,6 @@ static void sierra_instat_callback(struc
struct sierra_port_private *portdata = usb_get_serial_port_data(port);
struct usb_serial *serial = port->serial;
- dev_dbg(&port->dev, "%s\n", __func__);
dev_dbg(&port->dev, "%s: urb %p port %p has data %p\n", __func__,
urb, port, portdata);
@@ -551,12 +550,12 @@ static void sierra_instat_callback(struc
dev_dbg(&port->dev, "%s: error %d\n", __func__, status);
/* Resubmit urb so we continue receiving IRQ data */
- if (status != -ESHUTDOWN) {
+ if (port->port.count && status != -ESHUTDOWN && status != -ENOENT) {
urb->dev = serial->dev;
err = usb_submit_urb(urb, GFP_ATOMIC);
if (err)
- dev_dbg(&port->dev, "%s: resubmit intr urb "
- "failed. (%d)\n", __func__, err);
+ dev_err(&port->dev, "%s: resubmit intr urb "
+ "failed. (%d)\n", __func__, err);
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
