Re: [PATCH] xhci: handle stop ep on invalid CStream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On 13.11.2018 08:48, Henry Lin wrote:
Below Note in xHCI spec 6.4.2.1 describes a Transfer Event is generated
for Stop Endpoint Command on invalid CStream:

CStream is not valid until a Streams endpoint transitions to the Start
Stream state for the first time. A Transfer Event generated by a Stop
Endpoint Command shall report '0' in the TRB Pointer and TRB Length fields
if the command is executed and CStream is invalid. Refer to section 4.12.1.

But, current implementation will output below error messages once driver
receives the Transfer Event for invalid CStream:

[  133.184633] xhci_hcd 0000:01:00.2: ERROR Transfer event for unknown stream ring slot 1 ep 2
[  133.184635] xhci_hcd 0000:01:00.2: @000000046044a420 00000000 00000000 1b000000 01038001

This issue can be observed while uas driver is handling SCSI command that
connected UAS device doesn't support. UAS device rejects the unsupported
command and causes Data-In stream for SCSI command data stopped when
CStream is invalid.

This patch handles the transfer event to remove false error messages.


A patch by Sandeep Singh that takes care of the same COMP_STOPPED_LENGTH_INVALID
case with zero TRB pointer just got applied, so this should now be taken care of.

https://marc.info/?l=linux-usb&m=153753620603125&w=2

It's in Greg's usb-linus branch:
d9193ef xhci: Add check for invalid byte size error when UAS devices are connected.

-Mathias



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux